Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(Accordion): update typings #1333

Merged
merged 2 commits into from
Feb 21, 2017
Merged

style(Accordion): update typings #1333

merged 2 commits into from
Feb 21, 2017

Conversation

layershifter
Copy link
Member

Cleanups and updates typings for #1072.

* @param {SyntheticEvent} event - React's original SyntheticEvent.
* @param {object} data - All props.
*/
onConfirm?: (event: React.MouseEvent<HTMLDivElement>, data: AccordionTitleProps) => void;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, confirm here.

@layershifter
Copy link
Member Author

Copy-paste is evil 😄

@codecov-io
Copy link

codecov-io commented Feb 17, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@36c5762). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1333   +/-   ##
=========================================
  Coverage          ?   99.75%           
=========================================
  Files             ?      140           
  Lines             ?     2401           
  Branches          ?        0           
=========================================
  Hits              ?     2395           
  Misses            ?        6           
  Partials          ?        0
Impacted Files Coverage Δ
src/modules/Accordion/AccordionTitle.js 100% <ø> (ø)
src/modules/Accordion/Accordion.js 100% <ø> (ø)
src/modules/Accordion/AccordionContent.js 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36c5762...b3f41bd. Read the comment docs.

@levithomason levithomason merged commit 344fb7e into master Feb 21, 2017
@levithomason levithomason deleted the style/accordion branch February 21, 2017 00:06
@levithomason
Copy link
Member

Released in semantic-ui-react@0.66.0.

harel pushed a commit to harel/Semantic-UI-React that referenced this pull request Feb 25, 2017
* style(Accordion): update typings

* style(Accordion): update typings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants