Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(Form): convert component to stateless #1433

Merged
merged 1 commit into from
Mar 11, 2017
Merged

Conversation

layershifter
Copy link
Member

#1367 removed all handlers, so Form can be stateless now 😄

@layershifter layershifter changed the title style(Form): convert component to functional style(Form): convert component to stateless Mar 10, 2017
@codecov-io
Copy link

codecov-io commented Mar 10, 2017

Codecov Report

Merging #1433 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1433      +/-   ##
==========================================
+ Coverage   99.74%   99.74%   +<.01%     
==========================================
  Files         141      141              
  Lines        2354     2365      +11     
==========================================
+ Hits         2348     2359      +11     
  Misses          6        6
Impacted Files Coverage Δ
src/collections/Form/Form.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 206c777...06fb105. Read the comment docs.

@levithomason levithomason merged commit c748bfe into master Mar 11, 2017
@levithomason levithomason deleted the style/form branch March 11, 2017 20:45
@levithomason
Copy link
Member

🎉

@ak99372
Copy link

ak99372 commented Mar 13, 2017

What is the actual reason (or change request) to convert it to stateless and how do we handle submit or serialize the form from now on?

@levithomason
Copy link
Member

Please see the linked PR for before/after code examples for upgrading and more context on why the change.

@ak99372
Copy link

ak99372 commented Mar 13, 2017

Thx Levi I didn't see the reference to #1367 .

@levithomason
Copy link
Member

No worries, let me know if there are any further questions we could have answered.

@levithomason
Copy link
Member

Released in semantic-ui-react@0.67.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants