Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): add FAQ #1480

Merged
merged 4 commits into from
Mar 19, 2017
Merged

docs(readme): add FAQ #1480

merged 4 commits into from
Mar 19, 2017

Conversation

levithomason
Copy link
Member

@levithomason levithomason commented Mar 19, 2017

This PR adds an FAQ section to the README. It also standardizes the library name to "Semantic UI React", without hyphens. Lastly, several internal links within the doc were fixed.

@codecov-io
Copy link

codecov-io commented Mar 19, 2017

Codecov Report

Merging #1480 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1480   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files         141      141           
  Lines        2371     2371           
=======================================
  Hits         2365     2365           
  Misses          6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ca4d03...2aaf6b3. Read the comment docs.

@@ -301,7 +301,7 @@ A [`ui header`][5] accepts a size class. The `ui modal` has a *component part*

#### React Components & Sub Components

Top level Semantic-UI-React components correspond to SUI *components*. Stardust sub components correspond to SUI *component parts*.
Top level Semantic UI React components correspond to SUI *components*. Stardust sub components correspond to SUI *component parts*.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Standardized library name without hyphens.


This is a listing of example projects and guides that will help you integrate Semantic-UI-React into your new or existing projects.
## FAQ
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added FAQ section.

@@ -61,11 +75,11 @@ These great products are built on Semantic-UI-React. Add yours [here][22].
- http://www.brewhousesolutions.com
- https://www.lifebot.fr

## Voice Your Opinion :speech_balloon:
## Voice Your Opinion
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some headers had emoji and others did not. Standardized README headers to not have any emoji.

@@ -3,7 +3,7 @@ import { Card } from 'semantic-ui-react'

const CardExampleLinkCard = () => (
<Card
href='#link'
href='#card-example-link-card'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed link to example to use new anchor links (name of examle file).

<a href='http://react.semantic-ui.com/modules/modal#modal'>Modal</a>
</li>
<li>
<NavLink to='/elements/button#button-example-button'>Button</NavLink>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were <a> tags which caused a full page reload. Replaced with react-router-dom nav links and fixed paths to point to new anchors.

@levithomason levithomason merged commit 3fd65da into master Mar 19, 2017
@levithomason levithomason deleted the docs/faq-and-usage branch March 19, 2017 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants