chore(package): update to webpack 2 #1502

layershifter · 2017-03-24T09:37:44Z

This PR updates webpack to 2 version.

layershifter · 2017-03-24T13:21:24Z

config.js

  dir_umd_dist: 'dist/umd',
-  dir_server: 'server',
-  dir_test: 'test',


layershifter · 2017-03-24T13:21:40Z

config.js

@@ -35,10 +34,10 @@ const paths = {
  base,
  src: base.bind(null, config.dir_src),
  dist: base.bind(null, config.dir_dist),
-  test: base.bind(null, config.dir_test),


layershifter · 2017-03-24T13:22:31Z

config.js

@@ -53,30 +52,27 @@ config = Object.assign({}, config, {
  // ----------------------------------
  // Compiler Configuration
  // ----------------------------------
-  compiler_devtool: __DEV__ && 'cheap-source-map'
-  || __TEST__ && 'cheap-source-map'


karma-webpack use inline-source-map

We use karma-webpack-with-fast-source-maps which allows for faster file sourcemaps. Its main trick is that it only re-runs tests that have changed since the last run. With vanilla karma-webpack, if you change one test suite, all 7k+ tests will re-run.

I'm open to changes here but I'd like to address the issue of too many tests taking too long to run while we're at it, or stick with karma-webpack-with-fast-source-maps. Another option I've been considering is using something like the dot reporter to lighten up and speed up test output.

Reverted, karma-webpack-with-fast-source-maps works perfectly as I see.

layershifter · 2017-03-24T13:23:07Z

docs/app/Components/ComponentDoc/ComponentExample.js

@@ -146,7 +146,7 @@ class ComponentExample extends Component {
  getOriginalSourceCode = () => {
    const { examplePath } = this.props

-    if (!this.sourceCode) this.sourceCode = require(`!raw!docs/app/Examples/${examplePath}`)


Update loader's usage

layershifter · 2017-03-24T13:25:52Z

karma.conf.js

    webpack: {
      devtool: config.compiler_devtool,
-      module: Object.assign({}, webpackConfig.module, {
-        loaders: [
+      entry: './test/tests.bundle.js',


karma-webpack tells we don't need entry, however webpack didn't work without it

layershifter · 2017-03-24T13:27:05Z

package.json

@@ -108,7 +108,8 @@
    "karma-mocha-reporter": "^2.2.1",
    "karma-phantomjs-launcher": "^1.0.0",
    "karma-phantomjs-shim": "^1.4.0",
-    "karma-webpack-with-fast-source-maps": "^1.9.2",


I've replaced it with karma-webpack and karma-sourcemap-loader because it looks quite outdated.

However, karma-webpack is very slow :( I'll come back to this when I have some more time.

layershifter · 2017-03-24T13:27:38Z

package.json

-    "webpack-hot-middleware": "^2.15.0",
+    "webpack": "^2.3.1",
+    "webpack-dev-middleware": "^1.10.1",
+    "webpack-hot-middleware": "^2.17.1",


Updated versions

layershifter · 2017-03-24T13:27:52Z

test/specs/lib/isBrowser-test.js

-    require('imports?document=>undefined!src/lib/isBrowser').default.should.be.false()
-    require('imports?document=>null!src/lib/isBrowser').default.should.be.false()
+    require('imports-loader?document=>undefined!src/lib/isBrowser').default.should.be.false()
+    require('imports-loader?document=>null!src/lib/isBrowser').default.should.be.false()


Update loader's usage

layershifter · 2017-03-24T13:28:19Z

webpack.config.js

  )
 } else if (!__TEST__) {
  webpackConfig.plugins.push(
-    new webpack.optimize.OccurrenceOrderPlugin(),
-    new webpack.optimize.DedupePlugin(),


Cruft at now

codecov-io · 2017-03-24T13:35:59Z

Codecov Report

Merging #1502 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1502   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files         141      141           
  Lines        2384     2384           
=======================================
  Hits         2378     2378           
  Misses          6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 751bdde...0995151. Read the comment docs.

levithomason · 2017-03-25T07:13:50Z

config.js

+      },
+    },
+    __DEV__,
+    __DEBUG__: !!argv.debug,


__DEBUG__ is also cruft, note, this build system was copied from one of our production apps and not thoroughly updated, so it has some extra junk that we don't need.

Removed 👍

levithomason · 2017-03-25T07:25:07Z

karma.conf.js

+const formatError = (msg) => {
+  let haveSeenStack = false
+  return msg
+    .split('\n')


This formatter is also borked and I'd like to clean it up with this PR. It used to receive the full stack and filter out blackboxed scripts, however, some time ago it began receiving each line of the stack trace instead. This is why the assertions have had so much extra whitespace in them.

I'll push a fix for this.

Turns out Karma needs a fix first, karma-runner/karma#2627

levithomason · 2017-03-25T08:34:14Z

karma.conf.js

          {
            test: /sinon\.js$/,
-            loader: 'imports?define=>false,require=>false',
+            loader: 'imports-loader?define=>false,require=>false',


This is no longer required after the sinon 2 update. We just need to rebase this branch.

levithomason · 2017-03-25T08:39:07Z

webpack.config.js

@@ -157,20 +153,20 @@ webpackConfig.module.loaders = [{
 // Local modules can still be enabled (ie for offline development)
 // in TEST we need local modules because karma uses a different index.html (no CDNs)
 if (__TEST__ || argv.localModules) {


This is more complication that I've never made use of in 2 years (maybe once?). Unless you use it, I say we drop it. It allows for running the project without an internet connection, provided you've already installed node_modules. You'll still get all the network errors due to CDNs failing to load, but, the local node_modules versions will be used instead.

However, this one feature alone requires us to have the style-loader, css-loader, sass-loader, file-loader, and yargs. All these can go away if we drop this feature.

Removed 👍

levithomason · 2017-03-25T09:15:03Z

2.3.2 is out, #1506

layershifter · 2017-03-25T19:07:53Z

I've pushed a commit:

changed webpack version to 2.3.2
karma-webpack-with-fast-source-maps returned 😄
removed logic with Local Modules

layershifter · 2017-04-02T15:13:14Z

@levithomason is there something that stops merging of this PR?

levithomason · 2017-04-02T21:17:40Z

Testing this now, thanks for the ping.

levithomason · 2017-04-02T21:36:21Z

webpack.config.js

-      loader: 'file',
-    },
-  ]
-} else {


We still need the else branch here as it is applicable when not in tests. I'll review it and push an update.

After restoring, the docs gulp task dropped from 1.8m to 24s, woop!

levithomason · 2017-04-02T23:22:08Z

I've finished reviewing and updating this PR. I've restored some build performance config we had previously and I also remove some deps that we don't need. Will merge on pass.

layershifter mentioned this pull request Mar 24, 2017

Update webpack to version 2.3.1 🚀 #1498

Closed

layershifter commented Mar 24, 2017

View reviewed changes

config.js

dir_umd_dist: 'dist/umd',

dir_server: 'server',

dir_test: 'test',

Copy link

Member Author

layershifter Mar 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cruft.

layershifter commented Mar 24, 2017

View reviewed changes

layershifter force-pushed the chore/webpack branch 2 times, most recently from 3e86db6 to 524cee3 Compare March 24, 2017 13:24

layershifter commented Mar 24, 2017

View reviewed changes

layershifter force-pushed the chore/webpack branch from 524cee3 to 8fed8f8 Compare March 24, 2017 13:29

layershifter added the ready for review label Mar 24, 2017

levithomason reviewed Mar 25, 2017

View reviewed changes

levithomason mentioned this pull request Mar 25, 2017

Update webpack to version 2.3.2 🚀 #1506

Closed

levithomason force-pushed the chore/webpack branch from 0e689b3 to b72482a Compare April 2, 2017 21:25

levithomason reviewed Apr 2, 2017

View reviewed changes

Alexander Fedyashov and others added 4 commits April 2, 2017 15:34

chore(package): update to webpack 2

954fa30

chore(package): update to webpack 2

4a39aa6

chore(karma): update formatError for single lines

6a22680

chore(webpack): fix review comments

175cbaa

levithomason added 3 commits April 2, 2017 15:35

chore(config): remove unused config

81a2af4

chore(webpack): restore noParse and externals

2ced631

chore(webpack): remove unused SCSS rule

00dbe03

levithomason force-pushed the chore/webpack branch from b14f873 to 1ee7ffe Compare April 2, 2017 22:36

levithomason added 4 commits April 2, 2017 15:49

chore(webpack): fix config comments

1641093

fix(webpack): do not override conditional config

626d5b8

chore(watch): remove dep

b323fce

fix(karma): remove sourcemap preprocessor

751f4f2

levithomason force-pushed the chore/webpack branch from 3886d2c to be5bb68 Compare April 2, 2017 22:49

levithomason added 2 commits April 2, 2017 16:17

chore(yargs): remove dep

a9ba2f5

fix(webpack.dll): remove unused loaders

0995151

levithomason force-pushed the chore/webpack branch from 527d012 to 0995151 Compare April 2, 2017 23:17

levithomason merged commit 99fa867 into master Apr 2, 2017

levithomason deleted the chore/webpack branch April 2, 2017 23:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(package): update to webpack 2 #1502

chore(package): update to webpack 2 #1502

layershifter commented Mar 24, 2017 •

edited

Loading

layershifter Mar 24, 2017

layershifter Mar 24, 2017

layershifter Mar 24, 2017

levithomason Mar 25, 2017

layershifter Mar 25, 2017

layershifter Mar 24, 2017

layershifter Mar 24, 2017

layershifter Mar 24, 2017

levithomason Mar 25, 2017

layershifter Mar 25, 2017

layershifter Mar 24, 2017

layershifter Mar 24, 2017

layershifter Mar 24, 2017

codecov-io commented Mar 24, 2017 •

edited

Loading

levithomason Mar 25, 2017 •

edited

Loading

layershifter Mar 25, 2017

levithomason Mar 25, 2017

levithomason Mar 25, 2017

levithomason Mar 25, 2017

levithomason Mar 25, 2017

layershifter Mar 25, 2017

levithomason commented Mar 25, 2017

layershifter commented Mar 25, 2017

layershifter commented Apr 2, 2017

levithomason commented Apr 2, 2017

levithomason Apr 2, 2017

levithomason Apr 2, 2017

levithomason commented Apr 2, 2017

chore(package): update to webpack 2 #1502

chore(package): update to webpack 2 #1502

Conversation

layershifter commented Mar 24, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-io commented Mar 24, 2017 • edited Loading

Codecov Report

levithomason Mar 25, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

levithomason commented Mar 25, 2017

layershifter commented Mar 25, 2017

layershifter commented Apr 2, 2017

levithomason commented Apr 2, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

levithomason commented Apr 2, 2017

layershifter commented Mar 24, 2017 •

edited

Loading

codecov-io commented Mar 24, 2017 •

edited

Loading

levithomason Mar 25, 2017 •

edited

Loading