-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(TextArea): add focus() method #1602
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1602 +/- ##
==========================================
+ Coverage 99.74% 99.74% +<.01%
==========================================
Files 141 141
Lines 2396 2397 +1
==========================================
+ Hits 2390 2391 +1
Misses 6 6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gnowoel Thanks for PR, I've updated a test, now lint passes. LGTM 👍
Thanks much guys! |
@layershifter Thanks much for the test update! I felt frustrated about the failed tests since they passed on localhost :) |
Released in |
I want to focus a
TextArea
element with aref
, but theref
refers to a component instance rather than a DOM element. We already solved this problem forInput
by adding afocus()
method, which will relay the method invocation to the underlying DOM element. So, in this PR, I'd like to add the samefocus()
method to theTextArea
component.