feat(Dropdown): add upward prop #1603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levithomason
force-pushed
the
feat/dropdown-upward
branch
from
d9ab3e5
to
8880a8c
Compare
Codecov Report
@@ Coverage Diff @@
## master #1603 +/- ##
=======================================
Coverage 99.74% 99.74%
=======================================
Files 141 141
Lines 2398 2398
=======================================
Hits 2392 2392
Misses 6 6
Continue to review full report at Codecov.
|
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#720 raised the issue of opening a dropdown to the side with the most space available. This PR adds a manually configurable prop for doing this. A subsequent PR should measure the menu and apply this automatically.