-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Dropdown): add DropdownSearchInput component #1619
Conversation
7373464
to
f2e818a
Compare
Codecov Report
@@ Coverage Diff @@
## master #1619 +/- ##
==========================================
+ Coverage 99.75% 99.75% +<.01%
==========================================
Files 144 145 +1
Lines 2463 2475 +12
==========================================
+ Hits 2457 2469 +12
Misses 6 6
Continue to review full report at Codecov.
|
ea77d14
to
269bb54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@levithomason we are ready for review there 😄
…React into feat/dropdown-search-input # Conflicts: # index.d.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've rebased to master
and fixed lint issue. Ready for review
…React into feat/dropdown-search-input # Conflicts: # src/modules/Dropdown/Dropdown.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR was updated to master
, merge conflicts were solved.
]), | ||
|
||
/** A width of an input. */ | ||
width: PropTypes.oneOfType([ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer we just use the width
property within the style
prop instead of breaking it out into a separate prop. This way, all style props are always within style
and there is no guessing about which style props are top-level props.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback, will do 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@levithomason I've performed requested changes, width
and style
props were removed, unnecessary tests, too 👍
…React into feat/dropdown-search-input # Conflicts: # src/modules/Dropdown/Dropdown.js # test/specs/modules/Dropdown/Dropdown-test.js
6076075
to
b3431c1
Compare
…ithub.com/Semantic-Org/Semantic-UI-React into feat/dropdown-search-input # Conflicts: # src/modules/Dropdown/Dropdown.js
Released in |
Replaces #1481, discussion is there.