Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Progress): indicating progressbar does not change its color #1653

Merged
merged 2 commits into from
May 6, 2017
Merged

fix(Progress): indicating progressbar does not change its color #1653

merged 2 commits into from
May 6, 2017

Conversation

Bebersohl
Copy link
Contributor

@Bebersohl Bebersohl commented May 4, 2017 •
edited
Loading

Fixes #1650

@codecov-io
Copy link

codecov-io commented May 5, 2017 •
edited
Loading

Codecov Report

Merging #1653 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1653   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files         141      141           
  Lines        2398     2398           
=======================================
  Hits         2392     2392           
  Misses          6        6
Impacted Files Coverage Δ
src/modules/Progress/Progress.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feb53e0...e84864a. Read the comment docs.

layershifter
layershifter approved these changes May 6, 2017
View reviewed changes
Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added tests, LGTM 👍

@levithomason levithomason merged commit 5561613 into Semantic-Org:master May 6, 2017
@levithomason
Copy link
Member

Thanks for the PR!

@levithomason
Copy link
Member

Released in semantic-ui-react@0.68.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@layershifter layershifter layershifter approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Bebersohl @codecov-io @levithomason @layershifter