fix(docs): fix compatibility with IE #1659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
commented
May 7, 2017
| @@ -27,6 +35,7 @@ export const semanticUICSSRepoURL = 'https://github.com/Semantic-Org/Semantic-UI | |||
|
|
|||
| export const scrollToAnchor = () => { | |||
| const anchor = location.hash && document.querySelector(location.hash) | |||
| const offsetY = window.scrollY || window.pageYOffset | |||
There was a problem hiding this comment.
pageYOffset is alias for scrollY, but it's supported from IE 9
layershifter
force-pushed
the
docs/fixes-in-ie
branch
from
3431703
to
2f8f01f
Compare
layershifter
commented
May 7, 2017
| const scrollStep = Math.ceil((Math.abs(elementTop / 8))) * Math.sign(elementTop) | ||
| const isScrolledToTop = offsetY === 0 | ||
| const isScrolledToBottom = offsetY + document.body.clientHeight === document.body.scrollHeight | ||
| const scrollStep = Math.ceil((Math.abs(elementTop / 8))) * mathSign(elementTop) |
There was a problem hiding this comment.
Math.sign is not supported in IE at all.
layershifter
force-pushed
the
docs/fixes-in-ie
branch
from
2f8f01f
to
c0aec92
Compare
Codecov Report
@@ Coverage Diff @@
## master #1659 +/- ##
=========================================
Coverage ? 99.75%
=========================================
Files ? 141
Lines ? 2406
Branches ? 0
=========================================
Hits ? 2400
Misses ? 6
Partials ? 0Continue to review full report at Codecov.
|
|
Thanks for the updates. |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes docs compatibility with IE.