Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Form): safely prevent default on submit #1786

Merged
merged 1 commit into from
Jun 22, 2017

Conversation

levithomason
Copy link
Member

@levithomason levithomason commented Jun 22, 2017

Fixes #1769

This PR prevents default on submit events when there is no action.

@codecov-io
Copy link

Codecov Report

Merging #1786 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1786      +/-   ##
==========================================
- Coverage   99.75%   99.75%   -0.01%     
==========================================
  Files         142      142              
  Lines        2452     2445       -7     
==========================================
- Hits         2446     2439       -7     
  Misses          6        6
Impacted Files Coverage Δ
src/collections/Form/Form.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9b486c...4870f04. Read the comment docs.

@levithomason levithomason merged commit 65fd10c into master Jun 22, 2017
@levithomason levithomason deleted the feature/form-submit-prevent-default branch June 22, 2017 01:27
@levithomason
Copy link
Member Author

Released in semantic-ui-react@0.69.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants