fix(Tab): relax menuItem prop type #1823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested changes
Jun 30, 2017
There was a problem hiding this comment.
@levithomason typings should be also updated, use any there.
Whoops, it will be done only in #1812.
layershifter
approved these changes
Jun 30, 2017
levithomason
force-pushed
the
fix/menu-item
branch
from
e901148
to
37181e4
Compare
Codecov Report
@@ Coverage Diff @@
## master #1823 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 144 144
Lines 2463 2463
=======================================
Hits 2457 2457
Misses 6 6
Continue to review full report at Codecov.
|
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1822
The Tab was designed to allow any shorthand value to be passed as the
menuItem. The propType was limited to string.This PR relaxes the propType and adds an example with shorthand
menuItems.