fix(Tab): use correct onTabChange activeIndex #1890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1890 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 145 145
Lines 2477 2477
=======================================
Hits 2471 2471
Misses 6 6
Continue to review full report at Codecov.
|
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1888
The proposed
activeIndexwas being overridden by spreading props after it was set.Tests were passing due to forgiving
calledWithMatchlogic. I've updated tests to be more strict and added an explicit test.I've also updated the controlled example to handle
onTabChangein addition to the range input. This way we have test and doc coverage on this.