Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(mixed): update components styling #1949

Merged
merged 1 commit into from
Aug 10, 2017
Merged

Conversation

layershifter
Copy link
Member

Stripped from #1895. Doesn't have conflicts with current code-style.

@codecov-io
Copy link

Codecov Report

Merging #1949 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1949      +/-   ##
==========================================
- Coverage   99.77%   99.77%   -0.01%     
==========================================
  Files         148      148              
  Lines        2637     2636       -1     
==========================================
- Hits         2631     2630       -1     
  Misses          6        6
Impacted Files Coverage Δ
src/views/Comment/Comment.js 100% <ø> (ø) ⬆️
src/collections/Form/Form.js 100% <ø> (ø) ⬆️
src/modules/Sticky/Sticky.js 100% <ø> (ø) ⬆️
src/addons/Confirm/Confirm.js 100% <ø> (ø) ⬆️
src/modules/Tab/TabPane.js 100% <ø> (ø) ⬆️
src/collections/Message/Message.js 100% <ø> (ø) ⬆️
src/collections/Table/TableHeader.js 100% <ø> (ø) ⬆️
src/modules/Rating/RatingIcon.js 100% <ø> (ø) ⬆️
src/modules/Dropdown/DropdownSearchInput.js 100% <ø> (ø) ⬆️
src/modules/Accordion/AccordionTitle.js 100% <ø> (ø) ⬆️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e09c3a...49ddb78. Read the comment docs.

@levithomason
Copy link
Member

Wow, a ton of work. Thanks for that!

I would like to consider using prettier in the future to enforce code style and relieve us having to do this again. I've been using it in some other projects with moderately good results so far. There are some things we'd have to give up since there is 0 configuration, however, the tradeoff and standardization is likely worth it in the long run.

@levithomason levithomason merged commit 160223f into master Aug 10, 2017
@levithomason levithomason deleted the style/components branch August 10, 2017 20:33
@levithomason
Copy link
Member

Released in semantic-ui-react@0.71.4

levithomason pushed a commit that referenced this pull request Aug 20, 2017
* chore(package): update all dependencies

* style(mixed): fix lint issues

* chore(package): update deps, add es6 support to configs

* style(docs): revert Table and Menu changes, splitted to #1938

* style(docs): revert tests changes, splitted to #1939

* style(mixed): restore formatting

* style(mixed): revert tests changes, splitted to #1949

* style(configs): ESify configs

* chore(package): update deps

* style(mixed): fix lint issues

* style(eslint): cleanup configs

* fix(configs): fix import of webpack config

* chore(package): update package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants