Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Tab): add renderActiveOnly prop #1976

Merged
merged 4 commits into from
Aug 27, 2017
Merged

feat(Tab): add renderActiveOnly prop #1976

merged 4 commits into from
Aug 27, 2017

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Aug 17, 2017 •
edited
Loading

Fixes #1877.

@codecov-io
Copy link

codecov-io commented Aug 17, 2017 •
edited
Loading

Codecov Report

Merging #1976 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1976      +/-   ##
=========================================
+ Coverage    99.8%   99.8%   +<.01%     
=========================================
  Files         148     148              
  Lines        2589    2590       +1     
=========================================
+ Hits         2584    2585       +1     
  Misses          5       5
Impacted Files Coverage Δ
src/modules/Tab/TabPane.js 100% <100%> (ø) ⬆️
src/modules/Tab/Tab.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23ec465...452a793. Read the comment docs.

@layershifter
Copy link
Member Author

Has merge conflicts

Alexander Fedyashov added 2 commits August 21, 2017 11:42
layershifter
layershifter commented Aug 21, 2017
View reviewed changes
Copy link
Member Author

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solved merge conflict and merged with master, ready for review

@levithomason levithomason merged commit e3c4972 into master Aug 27, 2017
@levithomason levithomason deleted the feat/tab-render branch August 27, 2017 15:56
@levithomason
Copy link
Member

Released in semantic-ui-react@0.72.0

@drheinheimer
Copy link

Fyi, this change does not work. Setting renderActiveOnly={false} results in no panes being rendered.

@layershifter
Copy link
Member Author

It's not enough to set this prop to false, take a look on this and this examples.

@levithomason
Copy link
Member

It's not enough to set this prop to false,

We should make it so.

@drheinheimer
Copy link

Thanks for pointing out those examples. They worked. I'm still having trouble with the example that the OP in #1877 provides of Leaflet, but perhaps this is a Leaflet issue.

@drheinheimer drheinheimer mentioned this pull request Aug 30, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@layershifter @codecov-io @levithomason @drheinheimer