Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package): replace npm with yarn #2081

Merged
merged 16 commits into from
Sep 24, 2017
Merged

chore(package): replace npm with yarn #2081

merged 16 commits into from
Sep 24, 2017

Conversation

levithomason
Copy link
Member

@levithomason levithomason commented Sep 18, 2017

NPM is broken. package-lock.json still doesn't work, and even if it did, it only works for users using the latest npm cli. Users on old versions still get a worse experience a no lock file safety.

This PR:

  • replaces npm with yarn
  • upgrades CircleCI to v2

@levithomason
Copy link
Member Author

Well, I cannot seem to figure out why ChromeHeadless is not included with pupeteer when installing with yarn.

I will have to come back next time and SSH into the box for more debugging. This is the only thing blocking this PR!

@layershifter
Copy link
Member

max callStack

We regularly get max call stack errors on CI, I'm think that we increase this value:

   customLaunchers: {
      puppeteer: {
        base: 'ChromeHeadless',
        flags: ['--stack-trace-limit 50000']
      }
    }

I'm not sure, but it should work.

missing libs

Seems Docker image of Circle missing required libs. I think that the most correct solution is use own Docker image there.

FROM circleci/node:8

RUN apt-get update && \
apt-get install -yq gconf-service libasound2 libatk1.0-0 libc6 libcairo2 libcups2 libdbus-1-3 \
libexpat1 libfontconfig1 libgcc1 libgconf-2-4 libgdk-pixbuf2.0-0 libglib2.0-0 libgtk-3-0 libnspr4 \
libpango-1.0-0 libpangocairo-1.0-0 libstdc++6 libx11-6 libx11-xcb1 libxcb1 libxcomposite1 \
libxcursor1 libxdamage1 libxext6 libxfixes3 libxi6 libxrandr2 libxrender1 libxss1 libxtst6 \
ca-certificates fonts-liberation libappindicator1 libnss3 lsb-release xdg-utils wget

puppeteer/puppeteer#290

@codecov-io
Copy link

codecov-io commented Sep 24, 2017

Codecov Report

Merging #2081 into master will increase coverage by 3.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2081      +/-   ##
==========================================
+ Coverage   96.45%   99.76%   +3.31%     
==========================================
  Files         150      149       -1     
  Lines        2596     2589       -7     
==========================================
+ Hits         2504     2583      +79     
+ Misses         92        6      -86
Impacted Files Coverage Δ
src/elements/Button/ButtonGroup.js 100% <0%> (ø) ⬆️
src/modules/Accordion/AccordionTitle.js 100% <0%> (ø) ⬆️
src/behaviors/Visibility/Visibility.js 100% <0%> (ø) ⬆️
src/modules/Modal/Modal.js 100% <0%> (ø) ⬆️
src/elements/Button/Button.js 100% <0%> (ø) ⬆️
src/modules/Accordion/Accordion.js 100% <0%> (ø) ⬆️
src/modules/Dropdown/Dropdown.js 100% <0%> (ø) ⬆️
src/addons/Portal/Portal.js 100% <0%> (ø) ⬆️
src/modules/Popup/Popup.js 100% <0%> (ø) ⬆️
src/modules/Accordion/AccordionAccordion.js
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fbcd31...c258b15. Read the comment docs.

@levithomason
Copy link
Member Author

Thanks for the lead, the list of missing deps was indeed the issue. Instead of managing our own image, I just updated those deps as the first step on CI.

We did not, however, have the issues related to sandboxing so I have not added any flags for that.

I also added the increased stack trace flag, we'll see if that resolves the maximum call stack exceeded issue!

@levithomason levithomason merged commit 4c16c7f into master Sep 24, 2017
@levithomason levithomason deleted the chore/yarn branch September 24, 2017 17:53
@levithomason
Copy link
Member Author

Released in semantic-ui-react@0.74.0

@dvdzkwsk
Copy link
Member

Praise be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants