Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(mixed): fix spelling and grammar issues in comments and tests #2196

Merged
merged 2 commits into from
Oct 16, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const ListExampleCelled = () => (
<Image avatar src='/assets/images/avatar/small/daniel.jpg' />
<List.Content>
<List.Header>Poodle</List.Header>
A poodle, its pretty basic
A poodle, it's pretty basic
</List.Content>
</List.Item>
<List.Item>
Expand Down
2 changes: 1 addition & 1 deletion docs/app/Layouts/HomepageLayout.js
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ export default class HomepageLayout extends Component {

<Header as='h3' style={{ fontSize: '2em' }}>Did We Tell You About Our Bananas?</Header>
<p style={{ fontSize: '1.33em' }}>
Yes I know you probably disregarded the earlier boasts as non-sequitur filler content, but its really
Yes I know you probably disregarded the earlier boasts as non-sequitur filler content, but it's really
true.
It took years of gene splicing and combinatory DNA research, but our bananas can really dance.
</p>
Expand Down
2 changes: 1 addition & 1 deletion src/addons/Ref/Ref.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export default class Ref extends Component {
componentDidMount() {
const { innerRef } = this.props

// Heads up! Don't move this condition, it's a short circle that avoids run of `findDOMNode`
// Heads up! Don't move this condition, it's a short circuit that avoids run of `findDOMNode`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one made me chuckle :)

// if `innerRef` isn't passed
// eslint-disable-next-line react/no-find-dom-node
if (innerRef) innerRef(findDOMNode(this))
Expand Down
2 changes: 1 addition & 1 deletion src/elements/Divider/Divider.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export interface DividerProps {
/** Divider can segment content horizontally. */
horizontal?: boolean;

/** Divider can have it's colours inverted. */
/** Divider can have its colours inverted. */
inverted?: boolean;

/** Divider can provide greater margins to divide sections of content. */
Expand Down
2 changes: 1 addition & 1 deletion src/elements/Divider/Divider.js
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ Divider.propTypes = {
/** Divider can segment content horizontally. */
horizontal: PropTypes.bool,

/** Divider can have it's colours inverted. */
/** Divider can have its colours inverted. */
inverted: PropTypes.bool,

/** Divider can provide greater margins to divide sections of content. */
Expand Down
2 changes: 1 addition & 1 deletion src/elements/Input/Input.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export interface InputProps {
/** An Input field can show the data contains errors. */
error?: boolean;

/** Take on the size of it's container. */
/** Take on the size of its container. */
fluid?: boolean;

/** An Input field can show a user is currently interacting with it. */
Expand Down
2 changes: 1 addition & 1 deletion src/elements/Input/Input.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ class Input extends Component {
/** An Input field can show the data contains errors. */
error: PropTypes.bool,

/** Take on the size of it's container. */
/** Take on the size of its container. */
fluid: PropTypes.bool,

/** An Input field can show a user is currently interacting with it. */
Expand Down
2 changes: 1 addition & 1 deletion src/lib/customPropTypes.js
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export const suggest = suggestions => (props, propName, componentName) => {
}

/**
* Disallow other props form being defined with this prop.
* Disallow other props from being defined with this prop.
* @param {string[]} disallowedProps An array of props that cannot be used with this prop.
*/
export const disallow = disallowedProps => (props, propName, componentName) => {
Expand Down
2 changes: 1 addition & 1 deletion src/modules/Accordion/Accordion.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export interface AccordionProps extends AccordionAccordionProps {
/** Additional classes. */
className?: string;

/** Format to take up the width of it's container. */
/** Format to take up the width of its container. */
fluid?: boolean;

/** Format for dark backgrounds. */
Expand Down
2 changes: 1 addition & 1 deletion src/modules/Accordion/Accordion.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ Accordion.propTypes = {
/** Additional classes. */
className: PropTypes.string,

/** Format to take up the width of it's container. */
/** Format to take up the width of its container. */
fluid: PropTypes.bool,

/** Format for dark backgrounds. */
Expand Down
2 changes: 1 addition & 1 deletion src/modules/Popup/Popup.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export interface PopupProps extends PortalProps {
/** Simple text content for the popover. */
content?: SemanticShorthandItem<PopupContentProps>;

/** A Flowing popup have no maximum width and continue to flow to fit its content. */
/** A flowing Popup has no maximum width and continues to flow to fit its content. */
flowing?: boolean;

/** Header displayed above the content in bold. */
Expand Down
4 changes: 2 additions & 2 deletions test/specs/modules/Dropdown/Dropdown-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -561,7 +561,7 @@ describe('Dropdown', () => {
.should.not.have.descendants('.selected')
})
it('is set when clicking an item', () => {
// random item, skip the first as its selected by default
// random item, skip the first as it's selected by default
const randomIndex = 1 + _.random(options.length - 2)
wrapperMount(<Dropdown options={options} selection />)

Expand All @@ -575,7 +575,7 @@ describe('Dropdown', () => {
.should.have.prop('selected', true)
})
it('is ignored when clicking a disabled item', () => {
// random item, skip the first as its selected by default
// random item, skip the first as it's selected by default
const randomIndex = 1 + _.random(options.length - 2)

options[randomIndex].disabled = true
Expand Down
14 changes: 7 additions & 7 deletions test/specs/modules/Rating/Rating-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ describe('Rating', () => {
.should.not.have.className('selected')
wrapper
.find('RatingIcon[selected=true]')
.should.have.length(0, 'Some RatingIcons did not remove its "selected" prop')
.should.have.length(0, 'Some RatingIcons did not remove their "selected" prop')
})
})

Expand Down Expand Up @@ -139,7 +139,7 @@ describe('Rating', () => {

wrapper
.find('RatingIcon[selected=true]')
.should.have.length(0, 'Some RatingIcons did not remove its "selected" prop')
.should.have.length(0, 'Some RatingIcons did not remove their "selected" prop')
})
})

Expand All @@ -153,7 +153,7 @@ describe('Rating', () => {
.simulate('click')
wrapper
.find('RatingIcon[active=true]')
.should.have.length(5, 'Some RatingIcons did not retain its "active" prop')
.should.have.length(5, 'Some RatingIcons did not retain their "active" prop')
})

it('allows toggling when set to "auto" with a single icon', () => {
Expand Down Expand Up @@ -200,7 +200,7 @@ describe('Rating', () => {
.simulate('click')
wrapper
.find('RatingIcon[active=true]')
.should.have.length(0, 'Some RatingIcons did not remove its "active" prop')
.should.have.length(0, 'Some RatingIcons did not remove their "active" prop')
})

it('prevents clearing when false with a single icon', () => {
Expand All @@ -220,7 +220,7 @@ describe('Rating', () => {
.simulate('click')
wrapper
.find('RatingIcon[active=true]')
.should.have.length(5, 'Some RatingIcons did not retain its "active" prop')
.should.have.length(5, 'Some RatingIcons did not retain their "active" prop')
})
})

Expand Down Expand Up @@ -248,7 +248,7 @@ describe('Rating', () => {
.simulate('click')
wrapper
.find('RatingIcon[active=true]')
.should.have.length(3, 'Some RatingIcons lost its "active" prop')
.should.have.length(3, 'Some RatingIcons lost their "active" prop')
})

it('prevents icons from becoming selected on mouse enter', () => {
Expand Down Expand Up @@ -278,7 +278,7 @@ describe('Rating', () => {
wrapper.simulate('mouseLeave')
wrapper
.find('RatingIcon[selected=true]')
.should.have.length(3, 'Some RatingIcons lost its "selected" prop')
.should.have.length(3, 'Some RatingIcons lost their "selected" prop')
})

it('prevents icons from becoming active on click', () => {
Expand Down