-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make the rollout knob GKE deployer specific
Right now the `rollout` knob is global, and it applies to all deployers. However, each deployer has its own rollout story. E.g., single, multi - no rollout story, SSH - no rollout story, kube - up to the DevOps people how to do it. The rollout knob makes sense only for the GKE deployer, where we have a custom rollout strategy, so it makes sense to make the knob a GKE deployer specific knob. However, if in the future we'll decide to add a system component that can compute rollout strategies and it can be applied to many deployers, we can move it back. I will remove the `rollout` knob from the weaver repo in a followup PR.
- Loading branch information
Showing
6 changed files
with
59 additions
and
37 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters