Make the rollout knob GKE deployer specific #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now the `rollout` knob is global, and it applies to all deployers. However, each deployer has its own rollout story. E.g., single, multi - no rollout story, SSH - no rollout story, kube - up to the DevOps people how to do it. The rollout knob makes sense only for the GKE deployer, where we have a custom rollout strategy, so it makes sense to make the knob a GKE deployer specific knob. However, if in the future we'll decide to add a system component that can compute rollout strategies and it can be applied to many deployers, we can move it back. I will remove the `rollout` knob from the weaver repo in a followup PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the
rolloutknob is global, and it applies to all deployers. However, each deployer has its own rollout story. E.g., single, multi - no rollout story, SSH - no rollout story, kube - up to the DevOps people how to do it.The rollout knob makes sense only for the GKE deployer, where we have a custom rollout strategy, so it makes sense to make the knob a GKE deployer specific knob. However, if in the future we'll decide to add a system component that can compute rollout strategies and it can be applied to many deployers, we can move it back.
I will remove the
rolloutknob from the weaver repo in a followup PR.