Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BC6H_SF decoding error #2

Merged
merged 3 commits into from
Jul 18, 2022
Merged

Fix BC6H_SF decoding error #2

merged 3 commits into from
Jul 18, 2022

Conversation

REDxEYE
Copy link

@REDxEYE REDxEYE commented Jul 18, 2022

Fixes python-pillow#6344 case with signed float format.

Decoding error were caused by additional sign extend call after endpoint
transform, according to khronos documentation, you only suppose to sign
extend endpoints only once, further calls to sign extend mangles
endpoint data.

Changes proposed in this pull request:

  • Remove unneded sign extention call in BC6 decoding function

Decoding error were caused by additional sign extend call after endpoint
transform, according to khronos documentation, you only suppose to sign
extend endpoints only once, further calls to sign extend mangles
endpoint data.
@ShadelessFox ShadelessFox merged commit efe48ac into ShadelessFox:main Jul 18, 2022
radarhere pushed a commit that referenced this pull request Aug 2, 2022
Check that orientation is still absent after reloading Exif
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DDS BC6 decoding has a broken blue channel
2 participants