Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the version test since the latest release. #312

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

boenrobot
Copy link

@boenrobot boenrobot commented Jan 17, 2023

Future releases should update the digits in the loops to match the largest number that this part of the version vector has ever reached. For the middle part, this is now 22, but the last part is now preemptively increased to 99.

NOTE: Remaining CI issues are both due to PHP extensions.

The PHP 8.1+ failures are discussed in #305

The PHP 8.2+ deprecation notice appears to be related to the memcache extension, which only recently fixed this notice, and I guess haven't made a release since fixing it. See websupport-sk/pecl-memcache@26c0f51

@boenrobot boenrobot force-pushed the version-test-fix branch 2 times, most recently from dadea61 to 5c5eb1b Compare January 17, 2023 16:01
@boenrobot boenrobot changed the title Fixed the version test since the latest release. [WIP] Fixed the version test since the latest release. Jan 17, 2023
@boenrobot boenrobot changed the title [WIP] Fixed the version test since the latest release. Fixed the version test since the latest release. Jan 17, 2023
Future releases should update the digits in the loops to match the largest number that this part of the version vector has ever reached. For the middle part, this is now 22, but the last part is now preemptively increased to 99.
@glensc glensc merged commit 59f3291 into Shardj:master Jan 17, 2023
@boenrobot boenrobot deleted the version-test-fix branch January 19, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants