Partial helper pull vars from view model #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Root cause come from this PR Shardj#268 (comment)
…l data Root cause come from this PR Shardj#268 (comment)
|
Mr @glensc could you please review this PR, thanks. |
hungtrinh
changed the title
|
hungtrinh
changed the title
Mr @glensc removed close keyword from title |
falkenhawk
added a commit
to zf1s/zf1
that referenced
this pull request
Jan 3, 2024
It looks like it's safe to use the `#[AllowDynamicProperties]` attribute, and it should still be valid for php 9.0 and not throw an error, contrary to what I understood at first. As per RFC: https://wiki.php.net/rfc/deprecate_dynamic_properties#proposal "The creation of dynamic properties on classes that aren't marked with the #[AllowDynamicProperties] attribute is deprecated in PHP 8.2 and becomes an Error exception in PHP 9.0." Related issues from zf1-future where they went with refactoring those classes to use a defined property to store all previously dynamic props in an array, which introduced breaking changes: Shardj/zf1-future#307 (comment) Shardj/zf1-future#261 Shardj/zf1-future#268 Shardj/zf1-future#328 Shardj/zf1-future#329
falkenhawk
added a commit
to zf1s/zend-form
that referenced
this pull request
Jan 4, 2024
It looks like it's safe to use the `#[AllowDynamicProperties]` attribute, and it should still be valid for php 9.0 and not throw an error, contrary to what I understood at first. As per RFC: https://wiki.php.net/rfc/deprecate_dynamic_properties#proposal "The creation of dynamic properties on classes that aren't marked with the #[AllowDynamicProperties] attribute is deprecated in PHP 8.2 and becomes an Error exception in PHP 9.0." Related issues from zf1-future where they went with refactoring those classes to use a defined property to store all previously dynamic props in an array, which introduced breaking changes: Shardj/zf1-future#307 (comment) Shardj/zf1-future#261 Shardj/zf1-future#268 Shardj/zf1-future#328 Shardj/zf1-future#329
falkenhawk
added a commit
to zf1s/zend-view
that referenced
this pull request
Jan 4, 2024
It looks like it's safe to use the `#[AllowDynamicProperties]` attribute, and it should still be valid for php 9.0 and not throw an error, contrary to what I understood at first. As per RFC: https://wiki.php.net/rfc/deprecate_dynamic_properties#proposal "The creation of dynamic properties on classes that aren't marked with the #[AllowDynamicProperties] attribute is deprecated in PHP 8.2 and becomes an Error exception in PHP 9.0." Related issues from zf1-future where they went with refactoring those classes to use a defined property to store all previously dynamic props in an array, which introduced breaking changes: Shardj/zf1-future#307 (comment) Shardj/zf1-future#261 Shardj/zf1-future#268 Shardj/zf1-future#328 Shardj/zf1-future#329
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #328
Explained root cause here #328 (comment).
Solution
check if second param of partial helper has method
getVarsthen use this method to pull model data for partial script