Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compataibility for php 8.2 to stop error Deprecated: Creation of dyna… #376

Merged
merged 1 commit into from
Sep 7, 2023
Merged

compataibility for php 8.2 to stop error Deprecated: Creation of dyna… #376

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions library/Zend/Controller/Action.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,12 @@ abstract class Zend_Controller_Action implements Zend_Controller_Action_Interfac
*/
public $view;

/**
* compataibility for php 8.2 to stop error Deprecated: Creation of dynamic property
* @var object
*/
public $contexts = null;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use a typed property?

Copy link
Collaborator

@develart-projects develart-projects Feb 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it's PHP and we don't really need that.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PHPDoc @var object now suggests it is an object, which it is not, it is an array


/**
* Helper Broker to assist in routing help requests to the proper object
*
Expand Down
Loading