Fixes to pass phpStan level 1

library/Zend/Amf/Parse/Resource/MysqliResult.php

@@ -31,7 +31,6 @@
  */
 class Zend_Amf_Parse_Resource_MysqliResult
 {
-
     /**
      * mapping taken from http://forums.mysql.com/read.php?52,255868,255895#msg-255895
      */
@@ -92,7 +91,6 @@ class Zend_Amf_Parse_Resource_MysqliResult
         "MYSQLI_TYPE_CHAR"        => 'string',
         "MYSQLI_TYPE_VARCHAR"     => 'string',
         "MYSQLI_TYPE_GEOMETRY"    => 'object',
-        "MYSQLI_TYPE_BIT"         => 'integer',
     ];
 
     /**

library/Zend/Amf/Parse/TypeLoader.php

@@ -62,7 +62,7 @@ final class Zend_Amf_Parse_TypeLoader
      */
     public static $classMap = [
         'flex.messaging.messages.AcknowledgeMessage' => 'Zend_Amf_Value_Messaging_AcknowledgeMessage',
-        'flex.messaging.messages.ErrorMessage'       => 'Zend_Amf_Value_Messaging_AsyncMessage',
+        'flex.messaging.messages.AsyncMessage'       => 'Zend_Amf_Value_Messaging_AsyncMessage',
         'flex.messaging.messages.CommandMessage'     => 'Zend_Amf_Value_Messaging_CommandMessage',
         'flex.messaging.messages.ErrorMessage'       => 'Zend_Amf_Value_Messaging_ErrorMessage',
         'flex.messaging.messages.RemotingMessage'    => 'Zend_Amf_Value_Messaging_RemotingMessage',
@@ -74,7 +74,7 @@ final class Zend_Amf_Parse_TypeLoader
      */
     protected static $_defaultClassMap = [
         'flex.messaging.messages.AcknowledgeMessage' => 'Zend_Amf_Value_Messaging_AcknowledgeMessage',
-        'flex.messaging.messages.ErrorMessage'       => 'Zend_Amf_Value_Messaging_AsyncMessage',
+        'flex.messaging.messages.AsyncMessage'       => 'Zend_Amf_Value_Messaging_AsyncMessage',
         'flex.messaging.messages.CommandMessage'     => 'Zend_Amf_Value_Messaging_CommandMessage',
         'flex.messaging.messages.ErrorMessage'       => 'Zend_Amf_Value_Messaging_ErrorMessage',
         'flex.messaging.messages.RemotingMessage'    => 'Zend_Amf_Value_Messaging_RemotingMessage',

library/Zend/Amf/Server.php

@@ -509,6 +509,7 @@ protected function _handle(Zend_Amf_Request $request)
 
         // create a response object to place the output from the services.
         $response = $this->getResponse();
+        $responseType = Zend_Amf_Constants::UNKNOWN_CONTENT_LENGTH;
 
         // set response encoding
         $response->setObjectEncoding($objectEncoding);

library/Zend/Auth/Adapter/Digest.php

@@ -71,6 +71,8 @@ class Zend_Auth_Adapter_Digest implements Zend_Auth_Adapter_Interface
      * @param  mixed $realm
      * @param  mixed $username
      * @param  mixed $password
+     *
+     * @phpstan-ignore-next-line (constructor.unusedParameter)
      */
     public function __construct($filename = null, $realm = null, $username = null, $password = null)
     {

library/Zend/Auth/Adapter/OpenId.php

@@ -227,7 +227,7 @@ public function setHttpClient($client) {
      * Defined by Zend_Auth_Adapter_Interface.
      *
      * @throws Zend_Auth_Adapter_Exception If answering the authentication query is impossible
-     * @return Zend_Auth_Result
+     * @return Zend_Auth_Result|void
      */
     public function authenticate() {
         $id = $this->_id;
@@ -279,5 +279,4 @@ public function authenticate() {
             }
         }
     }
-
 }

library/Zend/Barcode/Object/ObjectAbstract.php

@@ -620,7 +620,7 @@ public function setText($value)
     public function getText()
     {
         $text = $this->_text;
-        if ($this->_withChecksum) {
+        if ($this->_withChecksum && method_exists($this, 'getChecksum')) {
             $text .= $this->getChecksum($this->_text);
         }
         return $this->_addLeadingZeros($text);

library/Zend/Barcode/Renderer/Image.php

@@ -442,6 +442,8 @@ protected function _drawText($text, $size, $position, $font, $color, $alignment
                 case 'right':
                     $positionX = $position[0] - ($fontWidth * strlen($text));
                     break;
+                default:
+                    $positionX = $position[0];
             }
             imagestring($this->_resource, $font, $positionX, $positionY, $text, $color);
         } else {
@@ -464,6 +466,8 @@ protected function _drawText($text, $size, $position, $font, $color, $alignment
                 case 'right':
                     $width = ($box[2] - $box[0]);
                     break;
+                default:
+                    $width = 0;
             }
             imagettftext(
                 $this->_resource,

library/Zend/Barcode/Renderer/Pdf.php

@@ -137,6 +137,9 @@ protected function _drawPolygon($points, $color, $filled = true)
     {
         $page = $this->_resource->pages[$this->_page];
 
+        $x = [];
+        $y = [];
+
         foreach ($points as $point) {
             $x[] = $point[0] * $this->_moduleSize + $this->_leftOffset;
             $y[] = $page->getHeight() - $point[1] * $this->_moduleSize - $this->_topOffset;

library/Zend/CodeGenerator/Php/File.php

@@ -168,7 +168,7 @@ public static function fromReflection(Zend_Reflection_File $reflectionFile)
             unset($bodyLines, $bodyReturn, $classStartLine, $classEndLine);
         }
 
-        if (($reflectionFile->getDocComment() != '')) {
+        if (isset($class) && $reflectionFile->getDocComment() != '') {
             $docblock = $reflectionFile->getDocblock();
             $file->setDocblock(Zend_CodeGenerator_Php_Docblock::fromReflection($docblock));
 
@@ -183,7 +183,7 @@ public static function fromReflection(Zend_Reflection_File $reflectionFile)
                 }
             }
             $body = implode("\n", $bodyReturn);
-            unset($bodyLines, $bodyReturn, $classStartLine, $classEndLine);
+            unset($bodyLines, $bodyReturn);
         }
 
         $file->setBody($body);

library/Zend/CodeGenerator/Php/Method.php

@@ -110,7 +110,8 @@ public static function fromReflection(Zend_Reflection_Method $reflectionMethod)
      */
     public function setFinal($isFinal)
     {
-        $this->_isFinal = ($isFinal) ? true : false;
+        $this->_isFinal = (bool)$isFinal;
+        return $this;
     }
 
     /**

library/Zend/Config/Writer/Xml.php

@@ -85,6 +85,7 @@ public function render()
      */
     protected function _addBranch(Zend_Config $config, SimpleXMLElement $xml, SimpleXMLElement $parent)
     {
+        $branchName = null;
         $branchType = null;
 
         foreach ($config as $key => $value) {

library/Zend/Console/Getopt.php

@@ -260,9 +260,8 @@ public function __construct($rules, $argv = null, $getoptConfig = [])
         if (!is_array($argv)) {
             $argv = array_slice($_SERVER['argv'], 1);
         }
-        if (isset($argv)) {
-            $this->addArguments((array)$argv);
-        }
+
+        $this->addArguments((array)$argv);
     }
 
     /**
@@ -518,7 +517,7 @@ public function toJson()
     public function toXml()
     {
         $this->parse();
-        $doc = new DomDocument('1.0', 'utf-8');
+        $doc = new DOMDocument('1.0', 'utf-8');
         $optionsNode = $doc->createElement('options');
         $doc->appendChild($optionsNode);
 

library/Zend/Date/Cities.php

@@ -128,7 +128,6 @@ class Zend_Date_Cities
         'Glasgow'     => ['latitude' =>   55.8333333, 'longitude' =>   -4.25],
         'Guatemala la Nueva' => ['latitude' => 14.6211111, 'longitude' => -90.5269444],
         'Hagatna'     => ['latitude' =>   13.47417,   'longitude' =>  144.74778],
-        'The Hague'   => ['latitude' =>   52.0833333, 'longitude' =>    4.3],
         'Hamilton'    => ['latitude' =>   32.2941667, 'longitude' =>  -64.7838889],
         'Hanoi'       => ['latitude' =>   21.0333333, 'longitude' =>  105.85],
         'Harare'      => ['latitude' =>  -17.8177778, 'longitude' =>   31.0447222],

library/Zend/Date/DateObject.php

@@ -713,6 +713,8 @@ protected function getDateParts($timestamp = null, $fast = null)
         $otimestamp = $timestamp;
         $numday = 0;
         $month = 0;
+        $year = 0;
+
         // gregorian correction
         if ($timestamp < -12219321600) {
             $timestamp -= 864000;
@@ -988,7 +990,7 @@ protected function calcSun($location, $horizon, $rise = false)
         // adjust quadrant
         if ($solLongitude > $threeQuarterCircle) {
             $solAscension += $fullCircle;
-        } else if ($solLongitude > $quarterCircle) {
+        } elseif ($solLongitude > $quarterCircle) {
             $solAscension += $halfCircle;
         }
 
@@ -1029,9 +1031,16 @@ protected function calcSun($location, $horizon, $rise = false)
         $universalTime    = ($universalTime - $min) * 60;
         $sec  = (int)$universalTime;
 
-        return $this->mktime($hour, $min, $sec, $this->date('m', $this->_unixTimestamp),
-                             $this->date('j', $this->_unixTimestamp), $this->date('Y', $this->_unixTimestamp),
-                             -1, true);
+        // @todo re-check removed arguement "-1"
+        return $this->mktime(
+            $hour,
+            $min,
+            $sec,
+            $this->date('m', $this->_unixTimestamp),
+            $this->date('j', $this->_unixTimestamp),
+            $this->date('Y', $this->_unixTimestamp),
+            true
+        );
     }
 
     /**
@@ -1094,6 +1103,7 @@ public function getTimezone()
      */
     public function getGmtOffset()
     {
+        $offset = 0;
         $date   = $this->getDateParts($this->getUnixTimestamp(), true);
         $zone   = @date_default_timezone_get();
         $result = @date_default_timezone_set($this->_timezone);

phpstan.dist.neon

@@ -0,0 +1,10 @@
+includes:
+    - phpstan.dist.baseline.neon
+    - phar://phpstan.phar/conf/bleedingEdge.neon
+parameters:
+    paths:
+        - library
+    level: 1
+    checkFunctionNameCase: true
+    checkInternalClassCaseSensitivity: true
+    treatPhpDocTypesAsCertain: false