Merge pull request #22 from Shipyrd/commit-message

Commit message

app/controllers/deploys_controller.rb

@@ -21,6 +21,7 @@ def deploy_params
       :recorded_at,
       :status,
       :performer,
+      :commit_message,
       :version,
       :service_version,
       :service,

app/views/applications/_application.html.erb

@@ -17,6 +17,10 @@
             </label>
 
             <progress class="<%= color %>" id="status" max="4" value="<%= deploy.progress_value %>"></progress>
+
+            <small>
+              <em><%= deploy.commit_message %></em>
+            </small>
           </p>
 
           <aside class="aside_naked">

config/brakeman.ignore

@@ -3,13 +3,13 @@
     {
       "warning_type": "Mass Assignment",
       "warning_code": 105,
-      "fingerprint": "1ccab913b33d7ba28d278629025289448792278e2b061e5ea8399948c5e6a365",
+      "fingerprint": "a530199ab745c10ef46d9af6485a3b454957b6774e4134ffa61bbdab36ded5ae",
       "check_name": "PermitAttributes",
       "message": "Potentially dangerous key allowed for mass assignment",
       "file": "app/controllers/deploys_controller.rb",
-      "line": 31,
+      "line": 32,
       "link": "https://brakemanscanner.org/docs/warning_types/mass_assignment/",
-      "code": "params.require(:deploy).permit(:recorded_at, :status, :performer, :version, :service_version, :service, :hosts, :command, :subcommand, :destination, :role, :runtime)",
+      "code": "params.require(:deploy).permit(:recorded_at, :status, :performer, :commit_message, :version, :service_version, :service, :hosts, :command, :subcommand, :destination, :role, :runtime)",
       "render_path": null,
       "location": {
         "type": "method",
@@ -24,6 +24,6 @@
       "note": ""
     }
   ],
-  "updated": "2024-05-13 15:26:40 -0700",
+  "updated": "2024-05-13 15:52:09 -0700",
   "brakeman_version": "6.1.2"
 }

config/environments/development.rb

@@ -2,6 +2,7 @@
 
 Rails.application.configure do
   # Settings specified here will take precedence over those in config/application.rb.
+  config.action_controller.action_on_unpermitted_parameters = :raise
 
   # In the development environment your application's code is reloaded any time
   # it changes. This slows down response time but is perfect for development

config/environments/test.rb

@@ -7,6 +7,7 @@
 
 Rails.application.configure do
   # Settings specified here will take precedence over those in config/application.rb.
+  config.action_controller.action_on_unpermitted_parameters = :raise
 
   # While tests run files are not watched, reloading is not necessary.
   config.enable_reloading = false

db/migrate/20240513224616_add_commit_message_to_deploys.rb

@@ -0,0 +1,5 @@
+class AddCommitMessageToDeploys < ActiveRecord::Migration[7.1]
+  def change
+    add_column :deploys, :commit_message, :string
+  end
+end

test/controllers/deploys_controller_test.rb

@@ -38,6 +38,7 @@ class DeploysControllerTest < ActionDispatch::IntegrationTest
               subcommand: "exec",
               recorded_at: Time.zone.now,
               performer: "nick",
+              commit_message: "New fancy things",
               version: "123456",
               service_version: "potato@123456",
               status: "pre-build",

test/system/applications_test.rb

@@ -47,11 +47,13 @@ class ApplicationsTest < ApplicationSystemTestCase
         command: :deploy,
         status: "post-deploy",
         version: "123456",
-        performer: "Nick"
+        performer: "Nick",
+        commit_message: "Deploying the potato"
       )
 
       assert_content "post-deploy"
       assert_content "by Nick"
+      assert_content "Deploying the potato"
 
       create(
         :deploy,