Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update button styling a bit, don't display url for a destination if not set #104

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Update button styling a bit, don't display url for a destination if not set #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/views/applications/_application.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@

<div class="column pt-1 is-two-fifths has-text-right">
<% if deploy.compare_url.present? %>
<%= link_to "Compare changes", deploy.compare_url, target: "_blank", class: "mr-3 button is-info is-small" %>
<%= link_to "Compare changes", deploy.compare_url, target: "_blank", class: "mr-3 button is-info is-small has-text-white" %>
<% end %>

<% if deploy.performer_avatar %>
Expand Down
2 changes: 1 addition & 1 deletion app/views/connections/_connections.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<% end %>
<% else %>
<span class="icon-text">
<%= link_to new_application_connection_path(@application, provider: :github, return_to: request.path), class: "button is-dark", title: "Connect GitHub" do %>
<%= link_to new_application_connection_path(@application, provider: :github, return_to: request.path), class: "button is-dark has-text-white", title: "Connect GitHub" do %>
<span class="icon">
<i class="fa-brands fa-github"></i>
</span>
Expand Down
2 changes: 1 addition & 1 deletion app/views/connections/_github.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<li>
Enter the new token below and click 'Connect to GitHub'

<div class="field">
<div class="field mt-2">
<div class="control">
<%= form.text_field :key, class: "input" %>
</div>
Expand Down
6 changes: 4 additions & 2 deletions app/views/destinations/_destination.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@
<div class="content">
<p>
<strong>URL:</strong>
<%= link_to destination.url, destination.url, target: "_blank", class: "is-link" %>
<% if destination.url.present? %>
<%= link_to destination.url, destination.url, target: "_blank", class: "is-link" %>
<% end %>
</p>

<p>
Expand All @@ -37,7 +39,7 @@
<% end %>
<% else %>
<span class="icon-text" style="margin-top: -0.2rem">
<%= link_to new_application_connection_path(application, provider: :github, return_to: request.path), class: "button is-dark is-small", title: "Connect GitHub" do %>
<%= link_to new_application_connection_path(application, provider: :github, return_to: request.path), class: "button is-dark is-small has-text-white", title: "Connect GitHub" do %>
<span class="icon is-small">
<i class="fa-brands fa-github"></i>
</span>
Expand Down
Loading