Skip to content

Commit

Permalink
Improve the logic and wording a bit
Browse files Browse the repository at this point in the history
  • Loading branch information
krzksz committed Jun 7, 2024
1 parent c9517fb commit b8d2838
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 17 deletions.
8 changes: 3 additions & 5 deletions sections/featured-collection.liquid
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,8 @@
role="list"
aria-label="{{ 'general.slider.name' | t }}"
>
{% assign skip_card_product_styles = false %}
{%- for product in section.settings.collection.products limit: section.settings.products_to_show -%}
{% assign skip_styles = false %}
{%- if forloop.index > 1 -%}
{%- assign skip_styles = true -%}
{%- endif -%}
<li
id="Slide-{{ section.id }}-{{ forloop.index }}"
class="grid__item{% if show_mobile_slider or show_desktop_slider %} slider__slide{% endif %}{% if settings.animations_reveal_on_scroll %} scroll-trigger animate--slide-in{% endif %}"
Expand All @@ -116,9 +113,10 @@
show_rating: section.settings.show_rating,
section_id: section.id,
quick_add: section.settings.quick_add,
skip_styles: skip_styles
skip_styles: skip_card_product_styles
%}
</li>
{%- assign skip_card_product_styles = true -%}
{%- else -%}
{%- for i in (1..section.settings.columns_desktop) -%}
<li
Expand Down
8 changes: 3 additions & 5 deletions sections/main-collection-product-grid.liquid
Original file line number Diff line number Diff line change
Expand Up @@ -150,11 +150,8 @@
{% if section.settings.quick_add == 'bulk' %} collection-quick-add-bulk{% endif %}
"
>
{% assign skip_card_product_styles = false %}

Check warning on line 153 in sections/main-collection-product-grid.liquid

View workflow job for this annotation

GitHub Actions / Theme Check Report

sections/main-collection-product-grid.liquid#L153

[LiquidTag] Use {% liquid ... %} to write multiple tags
{%- for product in collection.products -%}
{% assign skip_styles = false %}
{%- if forloop.index > 1 -%}
{%- assign skip_styles = true -%}
{%- endif -%}
{% assign lazy_load = false %}
{%- if forloop.index > 2 -%}
{%- assign lazy_load = true -%}
Expand All @@ -176,9 +173,10 @@
lazy_load: lazy_load,
quick_add: section.settings.quick_add,
section_id: section.id,
skip_styles: skip_styles
skip_styles: skip_card_product_styles
%}
</li>
{%- assign skip_card_product_styles = true -%}
{%- endfor -%}
</ul>

Expand Down
5 changes: 4 additions & 1 deletion sections/main-product.liquid
Original file line number Diff line number Diff line change
Expand Up @@ -552,6 +552,7 @@
aria-label="{{ 'general.slider.name' | t }}"
{% endif %}
>
{% assign skip_card_product_styles = false %}
{%- for i in (1..number_of_slides) -%}
<div
id="Slide-{{ block.id }}-{{ forloop.index }}"
Expand Down Expand Up @@ -582,9 +583,11 @@
quick_add: quick_add,
section_id: section.id,
horizontal_class: true,
horizontal_quick_add: true
horizontal_quick_add: true,
skip_styles: skip_card_product_styles
%}
</li>
{%- assign skip_card_product_styles = true -%}
{%- endfor -%}
</ul>
</div>
Expand Down
5 changes: 4 additions & 1 deletion sections/main-search.liquid
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,7 @@
class="grid product-grid grid--{{ section.settings.columns_mobile }}-col-tablet-down grid--{{ section.settings.columns_desktop }}-col-desktop"
role="list"
>
{%- assign skip_card_product_styles = false -%}

Check warning on line 257 in sections/main-search.liquid

View workflow job for this annotation

GitHub Actions / Theme Check Report

sections/main-search.liquid#L257

[LiquidTag] Use {% liquid ... %} to write multiple tags
{%- for item in search.results -%}
{% assign lazy_load = false %}
{%- if forloop.index > 2 -%}
Expand All @@ -276,8 +277,10 @@
show_secondary_image: section.settings.show_secondary_image,
show_vendor: section.settings.show_vendor,
show_rating: section.settings.show_rating,
lazy_load: lazy_load
lazy_load: lazy_load,
skip_styles: skip_card_product_styles
%}
{%- assign skip_card_product_styles = true -%}
{%- when 'article' -%}
{% render 'article-card',
article: item,
Expand Down
8 changes: 3 additions & 5 deletions sections/related-products.liquid
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,8 @@
class="grid product-grid grid--{{ section.settings.columns_desktop }}-col-desktop grid--{{ section.settings.columns_mobile }}-col-tablet-down"
role="list"
>
{% assign skip_card_product_styles = false %}
{% for recommendation in recommendations.products %}
{% assign skip_styles = false %}
{%- if forloop.index > 1 -%}
{%- assign skip_styles = true -%}
{%- endif -%}
<li class="grid__item">
{% render 'card-product',
card_product: recommendation,
Expand All @@ -48,9 +45,10 @@
show_secondary_image: section.settings.show_secondary_image,
show_vendor: section.settings.show_vendor,
show_rating: section.settings.show_rating,
skip_styles: skip_styles
skip_styles: skip_card_product_styles
%}
</li>
{%- assign skip_card_product_styles = true -%}
{% endfor %}
</ul>
{% endif %}
Expand Down

0 comments on commit b8d2838

Please sign in to comment.