Refactor liquid logic

Shopify · Aug 2, 2023 · d00933f · d00933f
1 parent 06e3a91
commit d00933f
Showing 1 changed file with 11 additions and 8 deletions.
diff --git a/sections/quick-order-list.liquid b/sections/quick-order-list.liquid
@@ -82,13 +82,19 @@
             </thead>
 
             <tbody>
+              {%- assign has_quantity_rules = false -%}
               {%- if product.has_only_default_variant -%}
                 {%- render 'quick-order-list-row',
                   item: product,
                   image: product.featured_media,
                   sku: product.selected_or_first_available_variant.sku,
                   variant: product.selected_or_first_available_variant
                 -%}
+                {% liquid
+                  if product.selected_or_first_available_variant.quantity_rule.min > 1 or product.selected_or_first_available_variant.quantity_rule.max != null or product.selected_or_first_available_variant.quantity_rule.increment > 1
+                    assign has_quantity_rules = true
+                  endif
+                %}
               {%- else -%}
                 {%- for variant in product.variants -%}
                   {%- render 'quick-order-list-row',
@@ -97,6 +103,11 @@
                     sku: variant.sku,
                     variant: variant
                   -%}
+                  {% liquid
+                    if variant.quantity_rule.min > 1 or variant.quantity_rule.max != null or variant.quantity_rule.increment > 1
+                      assign has_quantity_rules = true
+                    endif
+                  -%}
                 {%- endfor -%}
               {%- endif -%}
             </tbody>
@@ -128,14 +139,6 @@
         {% comment %} Populated by JS {% endcomment %}
       </span>
     {%- else -%}
-      {% liquid
-        assign has_quantity_rules = false
-        for variant in product.variants
-          if variant.quantity_rule.min > 1 or variant.quantity_rule.max != null or variant.quantity_rule.increment > 1
-            assign has_quantity_rules = true
-          endif
-        endfor
-      %}
       <div
         class="quick-order-list__total{% if product.quantity_price_breaks_configured? or has_quantity_rules %} has-info-icon{% endif %} gradient"
         id="quick-order-list-total"