Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to Cart Button Not Adding to Cart on Second Dimension Variants #636

Closed
chris-chameleonbrands opened this issue Sep 17, 2021 · 4 comments · Fixed by #656
Closed

Add to Cart Button Not Adding to Cart on Second Dimension Variants #636

chris-chameleonbrands opened this issue Sep 17, 2021 · 4 comments · Fixed by #656
Assignees
Labels
Severity: 1 Urgent Severity

Comments

@chris-chameleonbrands
Copy link

chris-chameleonbrands commented Sep 17, 2021

Describe the current behavior
Currently, when an item has Variants, say Colour and Size in my example, when you change products to second dimension variant and press add to cart there is no add to cart action for the item.

Describe the expected behavior

Item is added to cart.

Version information (Dawn, browsers and operating systems)

  • Dawn Version: 2.1.0
  • Chrome Version 91.0.4472.114
  • macOS Version 11.3.1

Possible solution

Additional context/screenshots
Video
Attached

Variant.Selector.Issue.mov
@gregjotau
Copy link

@chris-chameleonbrands check if this works: #633

I discussed it here with @ludoboludo and a temp fix worked for me at famme.no

@chris-chameleonbrands
Copy link
Author

@gregjotau

Thanks for your comment, I had a quick look and tested the cart.js and cart.notification.liquid commits and that doesn't seem to have resolved the issue.

@chris-chameleonbrands
Copy link
Author

@gregjotau on a side note, how did you get the variant.image as the option instead of the words? looks real nice.

@gregjotau
Copy link

gregjotau commented Sep 20, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Severity: 1 Urgent Severity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants