Slideshow previous button disabled fix #1032
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes introduced?
Fixes an issue where the previous button on the slideshow is disabled. It doesn't come up when you first add the section in the editor but does once you've saved.
Didn't notice it before, so I'm wondering what could potentially have triggered it 🤔 Seems like an issue with the order in which functions/values are being called.
I think it's due to the fact that the slideshow component is extending the slider component and has a different value for
this.enableSliderLooping
. But when it runsupdate()
it's using thefalse
value set insliderComponent
first which disables the previous button and only after that it notices the different value set within the slideshow component.What approach did you take?
I added a check in the
update()
within the slideshow component. So that if it sees thedisabled
attribute it removes it.Other considerations
Demo links
Checklist