-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update footer.liquid #137
Update footer.liquid #137
Conversation
Missing dash in col classname.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ninasaeheng
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Nice catch!
@ninasaeheng you'll just need to ensure you sign the CLA before merging. |
Hi @ninasaeheng, as @chrisberthe mentioned, would it be possible to sign in the CLA so we can merge it? |
@tauthomas01 @chrisberthe sorry, signed! |
@ninasaeheng I still see the CLA not being signed. |
I re-run the CLA test, and it works well now 👍 |
Missing dash in col classname.
Missing dash in col classname.
grid--4col-desktop
>grid--4-col-desktop