Updating headings to use the proper font weight #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmeleta
approved these changes
Jul 14, 2021
|
@melissaperreault This should fix the weird font stuff you were experiencing - good catch. |
phapsidesGT
pushed a commit
to Gravytrain-UK/gt-shopify-dawn-theme
that referenced
this pull request
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes introduced?
Font weight for headings was set to
normalwhich meant that changing font settings in the theme's Typography settings didn't change the heading weight as expected.To test, change around some body/heading fonts and weights and make sure they change appropriately.
To see the bug that was manifesting before, go to the
mainbranch and try setting the same font for both the Body and Headings and then change the Heading font to a non-normal font i.e. Extra Light and the Body font to Normal. Note that the heading font will then render as Normal.Demo links
Checklist