Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no js when animations are enabled #2501

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Fix no js when animations are enabled #2501

merged 1 commit into from
Apr 11, 2023

Conversation

ludoboludo
Copy link
Contributor

PR Summary:

Fix the no-js behaviour for animation so content is showing properly

Why are these changes introduced?

Right now the no js styling is targeting a class that is only added via JS.

What approach did you take?

I replaced the class used by the class that is added in liquid vs JS

Visual impact on existing themes

Should show all section by default properly in no-js.

Testing steps/scenarios

  • Enable the animation from the general settings
  • Then test the theme after disabling JS in the inspect tool

Demo links

Checklist

Copy link
Contributor

@kjellr kjellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@ludoboludo ludoboludo merged commit cbaf71d into main Apr 11, 2023
@ludoboludo ludoboludo deleted the fix-no-js-animation branch April 11, 2023 15:40
phapsidesGT pushed a commit to Gravytrain-UK/gt-shopify-dawn-theme that referenced this pull request Sep 3, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants