Modify info string for gift card recipient checkbox #2588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzarud
force-pushed
the
mzarud/modify_gc_string
branch
from
bf1b79f
to
432e5a2
Compare
ludoboludo
approved these changes
Apr 28, 2023
|
Hey @ludoboludo and @mzarud ! @danielvan asked me to take a look at the copy here. I have a suggestion for making it a bit shorter/clearer: Checkbox: lmk if you have any feedback - I realize I'm popping in without a ton of context so definitely open to your feedback. |
ludoboludo
reviewed
May 1, 2023
| @@ -2008,7 +2008,7 @@ | |||
| }, | |||
| "show_gift_card_recipient": { | |||
| "label": "Show recipient information form for gift card products", | |||
| "info": "Gift card products can optionally be sent direct to a recipient along with a personal message. [Learn more](https://help.shopify.com/manual/online-store/themes/customizing-themes/add-gift-card-recipient-fields)" | |||
| "info": "Gift card products can optionally be sent direct to a recipient on a scheduled date along with a personal message. [Learn more](https://help.shopify.com/manual/online-store/themes/customizing-themes/add-gift-card-recipient-fields)" | |||
There was a problem hiding this comment.
That works for us. I think we have some other minor improvements to ship in the next release anyways so I've created a GH issue to track this as well.
LucasLacerdaUX
approved these changes
May 2, 2023
|
I asked if we could rush the translations again FYI 😅 We should have them all soon 👍 |
ludoboludo
approved these changes
May 2, 2023
jabrms
pushed a commit
to fp-trading/fp-trading-theme
that referenced
this pull request
Jun 6, 2023
jabrms
pushed a commit
to fp-trading/fp-trading-theme
that referenced
this pull request
Jun 12, 2023
pangloss
added a commit
to pangloss/dawn
that referenced
this pull request
Jun 14, 2023
* shopify/main: (59 commits) [Announcement bar] Add social icons (Shopify#2497) Update theme version to match the pubic release (Shopify#2698) Add release/v10.0.0 branch fixes to main (Shopify#2693) fix default UI for dropdown and mega menu (Shopify#2644) Fix link formatting in Related Products heading (Shopify#2680) Update 2 translation files (Shopify#2637) Enable gift card recipient form by default on featured product section (Shopify#2666) Gift cards/enable recipient form by default (Shopify#2618) Add a Color Scheme setting for Menus-Header (Shopify#2622) Made mobile drawer full width by default-header (Shopify#2625) Allow multiple announcement bars in Header group (Shopify#2619) [Feat Product] Add rating styling sheet (Shopify#2620) Fix password page variables (Shopify#2607) Fix transform applied when it should not for sliders (Shopify#2606) Modify info string for gift card recipient checkbox (Shopify#2588) [3D lift animation] Raise hovered card above adjacent cards (Shopify#2589) Remove fallback color scheme info text (Shopify#2602) Fix CSS specifity issue to cancel animation for theme editor events (Shopify#2605) Remove settings daya for icon color (Shopify#2601) Follow ups for accessibility of announcements slider (Shopify#2580) ...
phapsidesGT
pushed a commit
to Gravytrain-UK/gt-shopify-dawn-theme
that referenced
this pull request
Sep 3, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
Closes https://github.com/Shopify/core-issues/issues/54765
This PR changes an informational string in the theme editor that is found beside the gift card recipient form enable/disable checkbox.
Existing string:
Why are these changes introduced?
We are releasing scheduling functionality in the recipient form with the next theme release, so we want to acknowledge that in the string.
Checklist