liquid render issues #3457
Open
liquid render issues #3457
+289
−420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Theme Check Summary. 203 files inspected with 16 total offenses found across 9 files. 2 errors. 14 warnings
|
I have signed the CLA! |
joshistoast
reviewed
May 8, 2024
layout/password.liquid
Outdated
|
|
||
| {%- render 'meta-tags' -%} | ||
| {%- render 'font-face' -%} | ||
| {%- render 'css-variable' -%} |
There was a problem hiding this comment.
Let's make font-face and css-variable be plural like how it is on meta-tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
The liquid undefined issues in the theme have been resolved to prevent potential server-side render blocking, ensuring smooth performance. This update does not involve any visual changes.
Fixes and Improvements:
Why are these changes introduced?
Created 2 snippets for theme.liquid just make them better arrangeable.
{%- render 'font-face' -%}
{%- render 'css-variable' -%}
Shopify theme Check issue report:
203 files inspected with 16 total offenses found across 9 files. 2 errors.
14 warnings
All are fixed.
Fixed all the liquid error and warnings as per theme checker shown.
Visual impact on existing themes:
There is no visual impact on theme
Checklist