Description defaults to true for collection #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sofiamatulis
approved these changes
Sep 7, 2021
| @@ -46,7 +46,7 @@ | |||
| { | |||
| "type": "checkbox", | |||
| "id": "show_collection_description", | |||
| "default": false, | |||
| "default": true, | |||
| "label": "t:sections.main-collection-banner.settings.show_collection_description.label" | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
I just noticed that even if the setting is on, but the string is empty it still renders the div
https://screenshot.click/07-41-0tkji-x4y83.png
Should we also be checking the length of the content?
{%- if section.settings.show_collection_description and collection.description.length > 0 -%}
<div class="collection-hero__description rte">{{ collection.description }}</div>
{%- endif -%}
There was a problem hiding this comment.
That should be fine, since we have div:empty { display: none }. This way, we can hide it without adding complexity to the Liquid.
There was a problem hiding this comment.
Oh yes 👍 I forgot about that. Thank you!
martinamarien
approved these changes
Sep 7, 2021
Merged
phapsidesGT
pushed a commit
to Gravytrain-UK/gt-shopify-dawn-theme
that referenced
this pull request
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes introduced?
Very quick PR to make the description on by default on the collection page. Discussed with @Oliviammarcello and Shawn Rudolph. This is good for SEO as well as for merchant expectations - they don't need to go to another place to see the collection description when they add one to their collection.
What approach did you take?
Switched a boolean 🤯
Checklist