Move cart item error after quantity field #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svinkle
previously approved these changes
Oct 7, 2021
LucasLacerdaUX
previously approved these changes
Oct 7, 2021
kmeleta
force-pushed
the
cart-error-placement
branch
from
10eae8f
to
5af888e
Compare
kmeleta
force-pushed
the
cart-error-placement
branch
from
aace196
to
0222d1e
Compare
melissaperreault
approved these changes
Oct 8, 2021
ludoboludo
approved these changes
Oct 20, 2021
LucasLacerdaUX
approved these changes
Oct 21, 2021
phapsidesGT
pushed a commit
to Gravytrain-UK/gt-shopify-dawn-theme
that referenced
this pull request
Sep 3, 2024
* Move cart item error after quantity field * Adjust error icon alignment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes introduced?
Fixes #470
What approach did you take?
Moved the
cart-item__errorcontent intocart-item__quantityso error messaging associated with the quantity input is closer in proximity. I also added acart-item__quantity-wrapperchild to help preserve the same flex wrapping styles as before.Other considerations
Are there other types of general error messages that are likely to appear here that wouldn't make sense after the quantity input?
Demo links
Checklist