Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to choose a package manager in hydrogen init #1958

Merged
merged 6 commits into from
Apr 9, 2024

Conversation

isaacroldan
Copy link
Contributor

@isaacroldan isaacroldan commented Apr 9, 2024

WHY are these changes introduced?

The Global CLI will run create-hydrogen and we need a way to either select a package manager or tell hydrogen to show a prompt to select one.

WHAT is this pull request doing?

  • Add a new --package-manager flag to the init command
  • Update cli-kit to latest version

HOW to test your changes?

Use npx shopify hydrogen init --package-manager pnpm to create a project using pnpm
Use npx shopify hydrogen init --package-manager unknown to force a prompt to select a package manager

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

Copy link
Contributor

shopify bot commented Apr 9, 2024

Oxygen deployed a preview of your global-cli-support branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
subscriptions ✅ Successful (Logs) Preview deployment Inspect deployment April 9, 2024 8:50 AM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment April 9, 2024 8:49 AM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment April 9, 2024 8:50 AM
vite ✅ Successful (Logs) Preview deployment Inspect deployment April 9, 2024 8:50 AM
skeleton ✅ Successful (Logs) Preview deployment Inspect deployment April 9, 2024 8:50 AM
optimistic-cart-ui ✅ Successful (Logs) Preview deployment Inspect deployment April 9, 2024 8:50 AM

Learn more about Hydrogen's GitHub integration.

Copy link
Contributor

github-actions bot commented Apr 9, 2024

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset.
If the changes are user-facing and should cause a version bump, run npm run changeset add to track your changes and include them in the next release CHANGELOG.
If you are making simple updates to examples or documentation, you do not need to add a changeset.

@isaacroldan isaacroldan changed the title Add support to choose a package manager in create-hydrogen Add support to choose a package manager in hydrogen init Apr 9, 2024
Copy link
Contributor

@frandiox frandiox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


Update cli-kit to latest version

I see you mentioned this but it's not changed in the PR. We are already upgrading to cli-kit 3.58 in #1946 so maybe we can merge this one as is?

@isaacroldan
Copy link
Contributor Author

Yeah, I initially planned to upgrade cli-kit but didn't. Forgot to remove that from the description

@isaacroldan
Copy link
Contributor Author

I can't merge the PR, so feel free to merge :)

@frandiox frandiox merged commit c84e985 into main Apr 9, 2024
13 checks passed
@frandiox frandiox deleted the global-cli-support branch April 9, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants