Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove added tunnel domains to Customer Application on process exit #1966

Merged
merged 6 commits into from
Apr 10, 2024

Conversation

frandiox
Copy link
Contributor

  • Ensure we copy .shopify back to the scaffolded diff examples so that we can cleanup tunnel domains the next time we run the process.
  • Ensure resources are cleaned up on process exit.
  • Best effort to remove tunnel domains on process exit.

It's easier to review this PR checking commit by commit.

To 🎩 :

  1. build packages
  2. run skeleton with npm run dev -- --customer-account-push__unstable
  3. Check that the tunnel domain is added in Admin
  4. ctrl^c to exit
  5. Check that the tunnel domain is removed in Admin

@frandiox frandiox requested a review from a team April 10, 2024 15:58
Copy link
Contributor

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset.
If the changes are user-facing and should cause a version bump, run npm run changeset add to track your changes and include them in the next release CHANGELOG.
If you are making simple updates to examples or documentation, you do not need to add a changeset.

Copy link
Contributor

@juanpprieto juanpprieto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎩 👍🏼

Copy link
Contributor

shopify bot commented Apr 10, 2024

Oxygen deployed a preview of your fd-ca-tunnel-improvements branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
vite ✅ Successful (Logs) Preview deployment Inspect deployment April 10, 2024 8:06 PM
subscriptions ✅ Successful (Logs) Preview deployment Inspect deployment April 10, 2024 8:07 PM
skeleton ✅ Successful (Logs) Preview deployment Inspect deployment April 10, 2024 8:01 PM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment April 10, 2024 8:06 PM
optimistic-cart-ui ✅ Successful (Logs) Preview deployment Inspect deployment April 10, 2024 8:06 PM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment April 10, 2024 8:06 PM

Learn more about Hydrogen's GitHub integration.

@frandiox
Copy link
Contributor Author

cc @michenly check this out when you're back :)

@frandiox frandiox merged commit a6e5606 into main Apr 10, 2024
13 checks passed
@frandiox frandiox deleted the fd-ca-tunnel-improvements branch April 10, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants