Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a magnifying glass example #2419

Merged
merged 7 commits into from
Jun 13, 2024
Merged

Add a magnifying glass example #2419

merged 7 commits into from
Jun 13, 2024

Conversation

rayronvictor
Copy link
Contributor

Gravacao.de.Tela.2024-05-09.as.08.48.53.mp4

@rayronvictor
Copy link
Contributor Author

I have signed the CLA!

@wcandillon
Copy link
Contributor

this is super cool thank you :)
I will review after app.js this week, hope it's ok 🙏

Copy link
Contributor

@wcandillon wcandillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice :)

@wcandillon
Copy link
Contributor

can you please fix the linting/tsc errors?
yarn lint --fix should do it. See: https://github.com/shopify/react-native-skia?tab=readme-ov-file#contributing

@wcandillon wcandillon self-requested a review June 4, 2024 07:40
Copy link
Contributor

@wcandillon wcandillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rayronvictor
Copy link
Contributor Author

can you please fix the linting/tsc errors? yarn lint --fix should do it. See: https://github.com/shopify/react-native-skia?tab=readme-ov-file#contributing

Done!

@wcandillon wcandillon merged commit 391fb9a into Shopify:main Jun 13, 2024
9 checks passed
@wcandillon
Copy link
Contributor

thanks a lot :)

wcandillon added a commit that referenced this pull request Jun 14, 2024
wcandillon added a commit that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants