Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: less strict theme type #125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: less strict theme type #125

wants to merge 1 commit into from

Conversation

Krisztiaan
Copy link

@Krisztiaan Krisztiaan commented Jan 27, 2022 •
edited
Loading

With this change, and eventually providing default generics, where appropriate, you could extend restyle with the theme.

declare module '@shopify/restyle' {
  export interface BaseTheme extends AppTheme {}
}

Without this change, the above extension would error with a circular dependency.

@Krisztiaan Krisztiaan changed the title chore: less invasive theme type chore: less strict theme type Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Krisztiaan