Upgrade esbuild to v0.23 #2261
Merged
Upgrade esbuild to v0.23 #2261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
bugfix
andrewn617
approved these changes
Jul 5, 2024
dirceu
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #2260
As pointed out in the issue, our bundle generation failed to include runtime dependencies because of evanw/esbuild#3819.
Upgrading esbuild to v0.23 fixes the issue (I built the extension and installed locally to test).
I'm not sure how we can catch something like this in CI, but it might be worth thinking about it. The extension is only packaged when publishing,
esbuildis not involved in running tests or using the development version of the extension, so we had no way of catching this ahead of time.