Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files via upload #7

Merged
merged 12 commits into from
Feb 13, 2024
Merged

Add files via upload #7

merged 12 commits into from
Feb 13, 2024

Conversation

momendiab
Copy link
Contributor

No description provided.

@lukasc-ubc
Copy link
Member

Please fix:

  • only one top cell is allowed
  • the phase shifters are applied to the waveguides going into the grating couplers. Note that the detectors cannot measure phase (only intensity) so you will not see any change with applied voltage. You need some circuit that converts phase into intensity, such as an interferometer.

@lukasc-ubc lukasc-ubc assigned lukasc-ubc and unassigned lukasc-ubc Feb 9, 2024
@lukasc-ubc lukasc-ubc self-requested a review February 9, 2024 09:35
Copy link
Member

@lukasc-ubc lukasc-ubc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix

@momendiab
Copy link
Contributor Author

Thanks Lukas!
The top 3 grating couplers are inputs. My understanding is that changing the voltage on one of the heaters will produce a sinusoidal change in intensity in the bottom (output) grating coupler.

@lukasc-ubc
Copy link
Member

we only have one laser as input. the other fibers are all detectors.

@momendiab
Copy link
Contributor Author

In that case, we'll have to split the one GC input into 3 ports and phase-shift them relative to each other to see the fringes. The latest layout has 2 circuits. One with heaters and one without.

@lukasc-ubc
Copy link
Member

Running verification on SiEPIC_Passives_momen_beamCombiner.gds
Traceback (most recent call last):
File "/home/runner/work/openEBL-2024-02-Si-Heaters/openEBL-2024-02-Si-Heaters/run_verification.py", line 26, in
top_cell = layout.top_cell()
RuntimeError: The layout has multiple top cells in Layout.top_cell

Also, in this design, the phase shifter won't do anything to the optical spectrum!

@lukasc-ubc
Copy link
Member

you have M1 and M2 crossing, but in this process these all become short circuits:

image

the way you have the pads is not correct. The two 2 pads should be for 1 heater, and the bottom 2 for the 2nd heater.

image

@lukasc-ubc
Copy link
Member

a phase shifter directly connected to a grating coupler doesn't make sense. Nothing will happen, other than the chip heating up a bit.

image

deleted all previous double-submissions. Fixed metal pads association to heaters.
deleted all previous double-submissions. Fixed metal pads association to heaters.
deleted all previous double-submissions. Fixed metal pads association to heaters. Added pad labels.
@momendiab momendiab closed this Feb 12, 2024
@momendiab momendiab reopened this Feb 12, 2024
@lukasc-ubc
Copy link
Member

there is only one file here. Is that intentional?

@lukasc-ubc lukasc-ubc merged commit c5017fc into SiEPIC:main Feb 13, 2024
4 checks passed
@momendiab
Copy link
Contributor Author

there is only one file here. Is that intentional?

Yes. The other files were older submissions with errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants