Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate use of old columns in traces #321

Merged
merged 4 commits into from
May 24, 2024

Conversation

makeavish
Copy link
Member

close: #42

@srikanthccv
Copy link
Member

Did we ever directly communicate with the users via some notification that we are deprecating these? This change should be preceded by identifying the views/dashboards/alerts that used the deprecated columns and automatically migrating them as much as possible. Otherwise, I think this will lead to issues as it removes some top-level columns users might have used in the product.

@makeavish
Copy link
Member Author

makeavish commented May 17, 2024

Did we ever directly communicate with the users via some notification that we are deprecating these? This change should be preceded by identifying the views/dashboards/alerts that used the deprecated columns and automatically migrating them as much as possible. Otherwise, I think this will lead to issues as it removes some top-level columns users might have used in the product.

We had a warning in our docs for a very long time: SigNoz/signoz.io#764
Component attribute existed since opentracing so it wouldn't have any values. grpcCode, grpcMethod, httpCode, tagMap were not returned as an attribute so users wouldn't have used them in views/dashboard built with query builder.
For clickhouse builder users had to read docs to know columns they can use and would have saw warnings.

Only concern might be externalHttpMethod and externalHttpUrl.

Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only concern might be externalHttpMethod and externalHttpUrl

May be let's exclude these for now and continue with the rest of the changes?

@makeavish makeavish merged commit 9d9d74d into main May 24, 2024
2 checks passed
@makeavish makeavish deleted the chore/deprecate-old-columns-in-traces branch May 24, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecate columns (clickhouse trace exporter)
2 participants