chore: add prepare query for delta/unspecified table #4168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankitnayan
reviewed
Jan 7, 2024
|
This PR just enables delta metrics with options of |
|
Yes, your understanding it correct. |
ankitnayan
approved these changes
Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part 4 of #4016
The
tablepanel type is almost the same as the time series panel but the line chart values in the timeframe are reduced to represent one value for each row. The reduced aggregation is usually (and by default) will beavg. In the new metrics improvements, We do not want to apply the reduced aggregation in the ClickHouse query itself as it is not cache friendly. We fetch the values for each result series and aggregate them in query-service (to come in follow-up PRs) before sending the response.