hotfix: move Executors initialization to a source file (#30)

Silver-Ore-Team · May 26, 2024 · 2dc9a17 · 2dc9a17
1 parent 29c2282
commit 2dc9a17
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 8 deletions.
diff --git a/src/NH/Executor.cpp b/src/NH/Executor.cpp
@@ -2,21 +2,22 @@
 
 namespace NH
 {
+    CommonExecutors Executors = {
+            .IO = ThreadPool("IO", std::thread::hardware_concurrency())
+    };
+
     ThreadPool::ThreadPool(const String& name, size_t threads)
             : Executor(), m_Name(name), log(NH::CreateLogger(String::Format("zBassMusic::ThreadPool({0})", name)))
     {
         for (size_t i = 0; i < threads; i++)
         {
-            m_Threads.emplace_back([this]()
+            auto& thread = m_Threads.emplace_back([this]()
                                    {
                                        log->Info("[thread-{0}] started", std::format("{}", std::this_thread::get_id()).c_str());
                                        EventLoop();
                                        log->Info("[thread-{0}] exiting", std::format("{}", std::this_thread::get_id()).c_str());
                                    });
-            for (auto& thread: m_Threads)
-            {
-                thread.detach();
-            }
+            thread.detach();
         }
     }
 

diff --git a/src/NH/Executor.h b/src/NH/Executor.h
@@ -51,7 +51,9 @@ namespace NH
         void EventLoop();
     };
 
-    struct {
-        ThreadPool IO = ThreadPool("IO", std::thread::hardware_concurrency());
-    } Executors;
+    struct CommonExecutors {
+        ThreadPool IO;
+    };
+
+    extern CommonExecutors Executors;
 }