bugfix: General Access Violation caused by too short lifetime of MusicDef #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrmacha
force-pushed
the
bufix/musicdef-ownership
branch
from
9d18b6c
to
0af0ccb
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MusicDefis used to store music themes config, and we need it for the whole lifetime of the application. However, the object was created byCMusicSys_Basson a stack and passed to theEngineas a reference. A moment later, the scope ofCMusicSys_Bassfunction finished andMusicDefwas deallocated despite being used by other classes.This change moves the ownership of
MusicDefto theEngine, so we can guarantee its lifetime.As a bonus feature, I added
HashStringthat can be used for compile-time string hashing (touint64_t) and as an efficient key for hash maps.