Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: don't play theme if music off #43

Merged
merged 2 commits into from
Jul 7, 2024
Merged

Bugfix: don't play theme if music off #43

merged 2 commits into from
Jul 7, 2024

Conversation

piotrmacha
Copy link
Member

Continuation of #42

PR taken over at will of the original PR contributor.

@piotrmacha piotrmacha mentioned this pull request Jul 7, 2024
Closed
muczc1wek
muczc1wek approved these changes Jul 7, 2024
View reviewed changes
Copy link
Member

@muczc1wek muczc1wek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if mentioning in docs, that the music won't be played is necessary, but it can stay. The rest is good

@piotrmacha piotrmacha merged commit 2da6f23 into main Jul 7, 2024
3 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muczc1wek muczc1wek muczc1wek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piotrmacha @muczc1wek @damianut