Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PIE-176 Support more WKTs #6

Merged
merged 12 commits into from
Sep 19, 2024
Merged

PIE-176 Support more WKTs #6

merged 12 commits into from
Sep 19, 2024

Conversation

puellanivis
Copy link

Adds additional types to the WKT support.

@puellanivis puellanivis requested a review from a team as a code owner September 17, 2024 09:49
@puellanivis puellanivis mentioned this pull request Sep 17, 2024
Closed
@puellanivis
Copy link
Author

I’ve now checked all the changes of the jsonschema between before and after this PR on eventschema and the only changes are proper type expectations for Timestamp and Duration. No other WKTs that are changing have been used so far.

@puellanivis puellanivis merged commit d37b57c into main Sep 19, 2024
2 checks passed
@puellanivis puellanivis deleted the PIE-176-support-timestamp branch September 19, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhimoondra abhimoondra abhimoondra approved these changes

@GrigoriyMikhalkin GrigoriyMikhalkin Awaiting requested review from GrigoriyMikhalkin GrigoriyMikhalkin is a code owner automatically assigned from Sixt/osre-pie

@robodenitro robodenitro Awaiting requested review from robodenitro robodenitro is a code owner automatically assigned from Sixt/osre-pie

@jfk-sixt jfk-sixt Awaiting requested review from jfk-sixt jfk-sixt is a code owner automatically assigned from Sixt/osre-pie

@dejan-kosak dejan-kosak Awaiting requested review from dejan-kosak dejan-kosak is a code owner automatically assigned from Sixt/osre-pie

@vivekr-nitk vivekr-nitk Awaiting requested review from vivekr-nitk vivekr-nitk is a code owner automatically assigned from Sixt/osre-pie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@puellanivis @abhimoondra