Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/add pact #35

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Feat/add pact #35

wants to merge 10 commits into from

Conversation

YOU54F
Copy link
Member

@YOU54F YOU54F commented Sep 3, 2024 •
edited
Loading

Overview

Add Pact to Explore.Cli to generate consumer contracts

  • Adds Pact-Net V5 Beta
  • Creates standalone ExploreHttpClient
  • Adds couple of simple Pact tests to get started
  • Adds Pact to CI/CD
    • publish pacts
    • can-i-deploy
    • record-release (as multiple cli versions released at any one time)

Changes

  • Pact tests for some functions in ExploreHttpClient

    • CheckSpaceExists
    • CreateSpace
    • CheckApiExists
    • CheckConnectionExists
    • UpsertSpace
    • UpsertApi
    • UpsertConnection
    • CreateApiEntry
    • CreateApiConnection

  • CI/CD

    • Publish pacts
    • Can-I-Deploy
    • Record Deployments / Releases
    • Readme badges
      • Can I Deploy
    • Provider verification - BDCT

Related

TODO

Will raise in new PR's

  • Update to use new ExploreHttpClient, see PR

@YOU54F YOU54F mentioned this pull request Sep 13, 2024
Open
3 tasks
@YOU54F YOU54F marked this pull request as ready for review September 13, 2024 14:12
@YOU54F
Copy link
Member Author

YOU54F commented Sep 13, 2024

Split out the consumption of the new client changes into #37

@YOU54F
chore: use updated pactflow v2 actions
a185bae
@YOU54F
test: cover mover ExploreHttpClient cases
e570509 
note: remaining

- UpsertSpace / UpsertApi / UpsertConnection

modified OAD for BDCT comparison. Updated included
@YOU54F
Copy link
Member Author

YOU54F commented Sep 17, 2024 •
edited
Loading

Uploaded updated OAD to SwaggerHub under 1.0.0-pactflow

https://app.swaggerhub.com/apis/smartbear/explore-spaces-service/1.0.0-pactflow

Compatibility comes back as valid 🎉

updated version

Compatibility Check

This API is compatible with the following consumer contracts

Consumer applications currently in development

API is compatible with the consumer contracts from the following applications:

  • Explore Cli

current version

https://app.swaggerhub.com/apis/smartbear/explore-spaces-service/1.0.0

Compatibility Check

This API is incompatible with some consumer contracts

Consumer applications currently in development

OAS Validation Errors

  1. discriminator: requires oneOf keyword

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankkilcommins frankkilcommins Awaiting requested review from frankkilcommins

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@YOU54F