🐛 Resolve the broken builds for older ruby versions #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewis-fidlers
changed the title
lewis-fidlers
changed the title
lewis-fidlers
changed the title
kinow
approved these changes
Jul 6, 2019
|
Not really necessary to test with a dashboard, but did that anyway. All working fine. Then tested # Running:
................
Fabulous run in 0.253890s, 63.0193 runs/s, 157.5483 assertions/s.
16 runs, 40 assertions, 0 failures, 0 errors, 0 skips
Coverage report generated for Unit Tests to /home/kinow/Development/ruby/workspace/smashing/coverage. 156 / 203 LOC (76.85%) covered.Travis is finally happy, so let's get it merged. Thanks a lot for your contribution @lewis-fidlers ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the build for some of the older ruby versions.
The actual issue comes from a change in Sinatra and is already fixed on their master branch for quite a while, however it is not in any of their releases. Seeing this affects only unsupported ruby versions it's probably not that cruacial.
The original issue and fix can be found here
As a fix for smashing I locked the Sinatra version to
2.0.4for ruby versions< 2.3.7However once Sinatra 2.0.6 is realeased everything should be fine again.
Also added in ruby
2.5.5and2.6.3, don't think the outdated versions should be removed, a dashboard is typically something that is not really touched once it's up and running.Closes #138